chore: migrate to nodeLinker: node-modules#817
chore: migrate to nodeLinker: node-modules#817MikeMcC399 wants to merge 2 commits intonodejs:mainfrom
Conversation
|
You have been asked to review. You wrote in #652 (comment)
As far as I can see, this would mean waiting many weeks to have CI working again, due to staged progress of Node.js releases. This PR provides an immediate mitigation and can be reverted later, if there is a better alternative. |
arcanis
left a comment
arcanis
left a comment
There was a problem hiding this comment.
As you wish - I don't have much bandwidth for Corepack currently.
|
If this could be merged, it should improve the chance of success for CI runs of the remaining open Dependabot PRs. Unfortunately there is some flakiness in the Windows tests though, as described in #821. I'm looking for a root cause, but have not so far been successful in getting to the bottom of it. I could probably use some help for that! |
3 participants
Situation
This repo is configured internally using yarn@4.11.0 (released Nov 2025) with the default Yarn Modern configuration setting nodeLinker: pnp.
As described in issue #813, the CI workflow ci.yml fails in Node.js 24.15.0, leading to an inability to maintain the repo.
The failing jobs are:
Assessment
Yarn Modern with
pnpsetting is not compatible with Node.js Active LTS 24.15.0Edit: Runner image update:
During deployments, which typically may take several days, GitHub Actions jobs may be served by either the previous image version or the one being deployed. This means that failures are random until the deployment has completed. Deployments can be monitored on actions/runner-images.
Attempting to resolve the issue by updating Yarn to the latest release yarn@4.14.1, keeping the default nodeLinker: pnp configuration, replaces the error condition
EBADFwith aTypeError. This is not a solution.A Node.js workaround has
also been proposednow been landed through PR nodejs/node#62835. This would need to be available in Node.js 24. There are many unknowns concerning the possible availability, including the delay in the release of Node.js 26.0.0. Possibly, if all goes well, the workaround could be available in mid May 2026 in Node.js 24. Relying on the workaround however would mean that in the interim period, Dependabot update PRs would fail, as would release PRs. The duration is also not predictable., and assumes that the open PR for the workaround will be approved and that it lands.Change
To fix the issue without delay, migrate the
nodeLinkerconfiguration setting from its default value to an explicitnode-modulessetting in a new .yarnrc.yml settings file:nodeLinker: pnpnodeLinker: node-modulesTo achieve this, cherry-pick 22a3fc0 from PR #652 originally submitted by @geigerzaehler.
The setting has no effect on the npm module published as corepack to the npm registry, apart from unblocking the ability to publish new versions of the package. The
nodeLinkersetting is not part of the published npm module.Verification
On Ubuntu 24.04.4 LTS, with Node.js 24.15.0 LTS, execute:
corepack yarn install corepack yarn build corepack yarn typecheck corepack yarn lint corepack yarn testConfirm no errors and all tests passing.